360 Secure SkillHub
360 安全技能中心

pr-review

按问题是否真实、价值是否足够、方案是否合理、实现是否正确、改动是否最小依次审查拉取请求,引用证据并给出 recommend-close、recommend-triage、recommend-revise 或 recommend-merge 结论。

分类:开发
wkentaro
热度 0.00
最近更新 2026-10-26 05:37:55

安装

发给 Agent
帮我安装这个技能:npx secure-skills-cli add wkentaro/agent-skills/pr-review
兼容性
通用兼容
联网要求
联网要求未确认
数据出网
数据出网未确认
Metadata
name
pr-review
description
Gut-check whether a pull request is meaningful, worth adding, the right approach, correct, and minimal, and give one recommend-* verdict.
argument-hint
[PR URL or #N ...]

PR Review

With PRs named, check each one. With none, check every open non-draft PR in the current repository that has no recommend-* label, one subagent per PR.

Check the title, description, and tests against the linked issue and the code at the head commit; they are claims.

Answer five questions in order, each with one line of evidence:

  1. Meaningful: is the problem real and still present on the base branch?
  2. Worth adding: does the value justify the scope and ongoing maintenance?
  3. Right approach: would you solve it this way, at the root cause, with a principled design that still holds as the code grows? A patch or special case that later changes must work around fails. Fail it only by naming an alternative and what it gains: a different design, or a refactor or architecture change that lands first and shrinks or removes this change.
  4. Correct: does it solve the problem without breaking a caller or edge case, and do the tests it adds for changed behavior fail on the base branch?
  5. Minimal: is every changed line needed, with nothing that existing code already does?

Take the first failure's verdict:

Fails Verdict
Meaningful, or Worth adding for a technical reason recommend-close
Worth adding as a product or scope call recommend-triage
Right approach, Correct, or Minimal recommend-revise
Nothing recommend-merge

Report to the caller the verdict, the five answers, and for revise the specific changes needed. The caller decides what reaches the PR.